Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Fix issue with updates not being blocked by QuotaRequest restrictions #2239

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

tylerslaton
Copy link
Contributor

This PR fixes an issue where updating an app would allow you to circumvent the need to wait for the new resources to be approved int he QuotaRequestInstance. Now, we check if an annotation on the QuotaRequestInstance matches that of the incoming AppInstance.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

pkg/controller/quota/quota.go Outdated Show resolved Hide resolved
pkg/controller/quota/quota.go Outdated Show resolved Hide resolved
pkg/labels/labels.go Outdated Show resolved Hide resolved
pkg/controller/quota/quota.go Outdated Show resolved Hide resolved
pkg/controller/quota/quota.go Outdated Show resolved Hide resolved
@tylerslaton tylerslaton force-pushed the fix-waiting-for-quota branch from 7d1943d to f11ca45 Compare October 12, 2023 18:40
pkg/controller/quota/quota.go Outdated Show resolved Hide resolved
@tylerslaton tylerslaton force-pushed the fix-waiting-for-quota branch from f11ca45 to fd0fc8d Compare October 13, 2023 13:58
@tylerslaton tylerslaton merged commit 7e1de06 into acorn-io:main Oct 13, 2023
4 checks passed
@tylerslaton tylerslaton deleted the fix-waiting-for-quota branch October 13, 2023 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants